feat: print optimizer param groups when verbose - #1149
Merged
Conversation
githubnemo
reviewed
Jul 22, 2026
githubnemo
left a comment
githubnemo
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for taking this on :)
The changes look good and nice to see tests from the start. I've made some comments.
- handle empty param_names in format_param_group_msg (unmapped params) - gate set_params printing to a specific param group, not global sets - revert unnecessary optimizer local; add no/multi-group + edge tests
Contributor
Author
|
Thanks for the review, @githubnemo! Addressed all three:
While adding the tests I also noticed |
githubnemo
reviewed
Jul 23, 2026
githubnemo
left a comment
githubnemo
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the changes, they look reasonable!
Two more comments but otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prints which module parameters match each optimizer param group when verbose is set, both at init and on set_params. Fixes #291.
Review fixes applied (8eeac24)
optimizerlocal inoptimizer_setter.format_param_group_msgnow reports params not among the module's learnable params instead of hiding them.set_paramsprinting to a specific param group so global sets (e.g.optimizer__lr) stay quiet.Review fixes applied (1608a15)
MAX_PARAM_GROUP_MSG_LEN(200 chars).